fix LCP Echo frequency

[l2tpns.git] / l2tpns.c

diff --git a/l2tpns.c b/l2tpns.c
index b923f7b..994116f 100644 (file)
--- a/l2tpns.c
+++ b/l2tpns.c
@@ -4,7 +4,7 @@
 // Copyright (c) 2002 FireBrick (Andrews & Arnold Ltd / Watchfront Ltd) - GPL licenced
 // vim: sw=8 ts=8
 
-char const *cvs_id_l2tpns = "$Id: l2tpns.c,v 1.141 2005-09-19 00:29:12 bodea Exp $";
+char const *cvs_id_l2tpns = "$Id: l2tpns.c,v 1.145 2005-10-18 07:19:28 bodea Exp $";
 
 #include <arpa/inet.h>
 #include <assert.h>
@@ -162,6 +162,7 @@ static char *plugin_functions[] = {
        "plugin_control",
        "plugin_radius_response",
        "plugin_radius_reset",
+       "plugin_radius_account",
        "plugin_become_master",
        "plugin_new_session_master",
 };
@@ -961,7 +962,7 @@ void tunnelsend(uint8_t * buf, uint16_t l, tunnelidt t)
        {
                tunnel[t].last = time_now; // control message sent
                tunnel[t].retry = backoff(tunnel[t].try); // when to resend
-               if (tunnel[t].try > 1)
+               if (tunnel[t].try)
                {
                        STAT(tunnel_retries);
                        LOG(3, 0, t, "Control message resend try %d\n", tunnel[t].try);
@@ -2745,7 +2746,7 @@ static void regular_cleanups(double period)
                        }
                }
                // Send hello
-               if (tunnel[t].state == TUNNELOPEN && (time_now - tunnel[t].lastrec) > 60)
+               if (tunnel[t].state == TUNNELOPEN && !tunnel[t].controlc && (time_now - tunnel[t].lastrec) > 60)
                {
                        controlt *c = controlnew(6); // sending HELLO
                        controladd(c, 0, t); // send the message
@@ -2931,7 +2932,8 @@ static void regular_cleanups(double period)
                }
 
                // No data in ECHO_TIMEOUT seconds, send LCP ECHO
-               if (session[s].ppp.phase >= Establish && (time_now - session[s].last_packet >= ECHO_TIMEOUT))
+               if (session[s].ppp.phase >= Establish && (time_now - session[s].last_packet >= ECHO_TIMEOUT) &&
+                       (time_now - sess_local[s].last_echo >= ECHO_TIMEOUT))
                {
                        uint8_t b[MAXETHER];
 
@@ -2946,6 +2948,7 @@ static void regular_cleanups(double period)
                        LOG(4, s, session[s].tunnel, "No data in %d seconds, sending LCP ECHO\n",
                                        (int)(time_now - session[s].last_packet));
                        tunnelsend(b, 24, session[s].tunnel); // send it
+                       sess_local[s].last_echo = time_now;
                        s_actions++;
                }
 
@@ -3411,18 +3414,19 @@ static void mainloop(void)
 
                if (time_changed)
                {
-                       double Mbps = ((1024.0 / 1024.0) * 8) / time_changed;
-                       time_changed = 0;
+                       double Mbps = 1024.0 * 1024.0 / 8 * time_changed;
 
                        // Log current traffic stats
                        snprintf(config->bandwidth, sizeof(config->bandwidth),
                                "UDP-ETH:%1.0f/%1.0f  ETH-UDP:%1.0f/%1.0f  TOTAL:%0.1f   IN:%u OUT:%u",
                                (udp_rx / Mbps), (eth_tx / Mbps), (eth_rx / Mbps), (udp_tx / Mbps),
-                               ((udp_tx + udp_rx + eth_tx + eth_rx) / Mbps), udp_rx_pkt, eth_rx_pkt);
+                               ((udp_tx + udp_rx + eth_tx + eth_rx) / Mbps),
+                               udp_rx_pkt / time_changed, eth_rx_pkt / time_changed);
                 
                        udp_tx = udp_rx = 0;
                        udp_rx_pkt = eth_rx_pkt = 0;
                        eth_tx = eth_rx = 0;
+                       time_changed = 0;
                 
                        if (config->dump_speed)
                                printf("%s\n", config->bandwidth);