- fix case where ll_delete removes the last entry

[l2tpns.git] / garden.c

diff --git a/garden.c b/garden.c
index 125cc44..059a001 100644 (file)
--- a/garden.c
+++ b/garden.c
@@ -9,7 +9,7 @@
 
 /* walled garden */
 
 
 /* walled garden */
 

-char const *cvs_id = "$Id: garden.c,v 1.14 2004/11/17 15:08:19 bodea Exp $";
+char const *cvs_id = "$Id: garden.c,v 1.16 2004/11/18 06:41:03 bodea Exp $";

 
 int plugin_api_version = PLUGIN_API_VERSION;
 static struct pluginfuncs *p = 0;
 
 int plugin_api_version = PLUGIN_API_VERSION;
 static struct pluginfuncs *p = 0;


@@ -76,15 +76,15 @@ int plugin_kill_session(struct param_new_session *data)
 }
 
 char *plugin_control_help[] = {
 }
 
 char *plugin_control_help[] = {

-       "  garden USER|SID           Put user into the walled garden",
-       "  ungarden USER|SID         Release user from garden",
+       "  garden USER|SID                             Put user into the walled garden",
+       "  ungarden SID                                Release session from garden",

        0
 };
 
 int plugin_control(struct param_control *data)
 {
        0
 };
 
 int plugin_control(struct param_control *data)
 {

-       sessionidt s;
-       sessiont *sess = 0;
+       sessionidt session;
+       sessiont *s = 0;

        int flag;
        char *end;
 
        int flag;
        char *end;
 


@@ -94,14 +94,10 @@ int plugin_control(struct param_control *data)
        if (strcmp(data->argv[0], "garden") && strcmp(data->argv[0], "ungarden"))
                return PLUGIN_RET_OK; // not for us
 
        if (strcmp(data->argv[0], "garden") && strcmp(data->argv[0], "ungarden"))
                return PLUGIN_RET_OK; // not for us
 

-       flag = data->argv[0][0] != 'u';
+       if (!iam_master)
+               return PLUGIN_RET_NOTMASTER;

 
 

-       if (!iam_master)        // All garden processing happens on the master.
-       {
-               data->response = NSCTL_RES_ERR;
-               data->additional = "must be run on the cluster master";
-               return PLUGIN_RET_STOP;
-       }
+       flag = data->argv[0][0] != 'u';

 
        if (data->argc != 2)
        {
 
        if (data->argc != 2)
        {


@@ -111,7 +107,12 @@ int plugin_control(struct param_control *data)
        }
 
        if (!(session = strtol(data->argv[1], &end, 10)) || *end)
        }
 
        if (!(session = strtol(data->argv[1], &end, 10)) || *end)

-               session = p->get_session_by_username(data->argv[1]);
+       {
+               if (flag)
+                       session = p->get_session_by_username(data->argv[1]);
+               else
+                       session = 0; // can't ungarden by username
+       }

 
        if (session)
                s = p->get_session_by_id(session);
 
        if (session)
                s = p->get_session_by_id(session);


@@ -131,7 +132,7 @@ int plugin_control(struct param_control *data)
        }
 
        garden_session(s, flag);
        }
 
        garden_session(s, flag);

-       p->sesssion_changed(session);
+       p->session_changed(session);

 
        data->response = NSCTL_RES_OK;
        data->additional = 0;
 
        data->response = NSCTL_RES_OK;
        data->additional = 0;